-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
chore(api): Rewrite Org Details docs #73293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #73293 +/- ##
===========================================
+ Coverage 57.06% 78.16% +21.09%
===========================================
Files 6641 6652 +11
Lines 297198 297584 +386
Branches 51183 51249 +66
===========================================
+ Hits 169594 232604 +63010
+ Misses 122877 58716 -64161
- Partials 4727 6264 +1537
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some copyedits. Thanks for updating!
required=False, | ||
) | ||
allowSharedIssues = serializers.BooleanField( | ||
help_text="Specify `true` to allow sharing of limited details on issues to anonymous users.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are anonymous users? This is the first time I've seen this mentioned. Is it users who aren't signed in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup exactly users who aren't signed in! i used the exact language used in the UI. it's for whether you can share public links of issues or not.
Bundle ReportChanges will increase total bundle size by 7.88kB ⬆️
|
Updates the OrganizationDetailsEndpoint docs to use the modern format + more detailed parameters + updated examples and schema